Repository navigation
Terrain MCP: a request's lake finds a basin, and every water body it names floods - #653
Merged
Merged
Conversation
…nd every water body it names floods 'a volcanic island with a lake' failed at the cook: the volcanic preset authors no lake layer, and the parser kept only the first water word, so the sea was lost too. - placeLakes puts each lake row the recipe has no layer for in the finished ground's deepest closed basin (fillDepressions), filled to its spill level, inside the square and above the sea; ground with no basin a metre deep floods its lowest inner cell two metres. Rivers keep routeRivers. - The request keeps every water body it names, once each: sea plus lake. Red: the lake spec threw 'no lake layer'. Green: ocean 1.5 m plus a lake at 4.5 m. Terrain 635/635.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
terrain_generatefailed on "a volcanic island with a lake". The volcanic landform has no lake layer, and the parser kept only the first water word, so the sea was lost too.Why does it matter?
An agent asks for any terrain in words and gets a world. A lake word now works on every landform, not only on the starters that author a lake.
Done
placeLakes: a lake row with no layer sits in the deepest closed basin of the finished ground (fillDepressions), filled to its spill level, inside the square and above the sea. Ground with no basin floods its lowest inner cell 2 m deep.no lake layer. It now gets an ocean at 1.5 m and a lake at 4.5 m.packages/terrain: 635/635.Follow-up to #635. Owner asked for an immediate merge that bypasses CI.